react-native-fused-location icon indicating copy to clipboard operation
react-native-fused-location copied to clipboard

Published 20 hours ago • verified publisher icon MustansirZia

Location settings dialog

Open hortemo opened this issue 7 years ago • 3 comments

Here is my draft for showing a dialog to programmatically set appropriate location settings. Based on https://developers.google.com/android/reference/com/google/android/gms/location/SettingsApi.

What are your thoughts?

hortemo avatar Feb 26 '18 22:02 hortemo

There is a very good PR I must say. I probably need to merge this and get this functionality in. But before I do that I need to dig deeper and see if I can refactor it a little more. For a start, may I ask why you used the depreciated Settings Api and not the newer SettingsClient?

MustansirZia avatar Feb 27 '18 16:02 MustansirZia

Feel free to refactor! I used the deprecated SettingsApi because you already used the deprecated FusedLocationProviderApi, and I thought those were from the same "generation" of APIs.

hortemo avatar Feb 27 '18 17:02 hortemo

@hortemo Alright. Would you be kind enough to send a PR with a SettingsClient usage instead? That'd be really great. As I'm planning to move on to the newer FusedLocationProviderClient pretty soon. :)

MustansirZia avatar Feb 28 '18 16:02 MustansirZia