desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Parameters in flags.go are not respected

Open Varunram opened this issue 6 years ago • 4 comments

Adding extra parameters (e.g. --port) to config/config.std.js are not respected while starting the gmc client. They should be.

Varunram avatar Jun 03 '18 21:06 Varunram

More info on this: We create a file at $HOME/config/ from which the wallet reads the config from. This is good, but this prevents the user from actually changing stuff within /config and then testing it. If we are to improve it in some way, we must either link both the files or have a musicoin.conf file as suggested in https://github.com/Musicoin/desktop-interface/issues/8

Varunram avatar Jun 03 '18 21:06 Varunram

Let's go ahead and close this with preference to Musicoin/desktop-interface#8 because the full solution is in filling that one.

etaletai13 avatar Jun 04 '18 00:06 etaletai13

Yeah, I guess that would be nice, but this is a more popular watched repo than the other one, so makes sense having this as well.

Varunram avatar Jun 24 '18 06:06 Varunram

Noted and agreed

etaletai13 avatar Jun 25 '18 13:06 etaletai13