desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Write proper tests

Open Varunram opened this issue 7 years ago • 10 comments

With the increasing number of facilities that the wallet offers, it becomes critical not to break certain features when introducing new ones. Towards this, we have to write test cases and test them using a CI (Travis/Circle would be fine I guess, Jenkins is also OK). Ideas welcome

Varunram avatar Feb 19 '18 11:02 Varunram

Upgrading the bounty on this one to 20k MC, which can be expanded upon in the future.

Varunram avatar Mar 30 '18 06:03 Varunram

On it. I hope somebody beats me to it though.

etaletai13 avatar Apr 02 '18 23:04 etaletai13

Okay, if all goes according to plan, I should be able to hook this nicely into a further minor bump after the yarn patch; so that yarn test is all you need to do; and I'll TRY to make a little menu for adding a new test. I have no idea why the ease of contributing is so important to me; but it really is.

etaletai13 avatar Apr 04 '18 19:04 etaletai13

tests are very, very important. it has been a few years sense i have written any good ones, last ones i did i used shoulda on RoR, along with a more complex suite that actually ran client side javascript (sometimes in a browser even).

does anyone have any specific plans for what we are going to do here? at least as far as which testing frameworks/suites/whatever they should be callled

movingelectrons avatar May 06 '18 04:05 movingelectrons

@movingelectrons I was considering doing scripted browser tests, considering that it does run on a browser's core.

etaletai13 avatar May 06 '18 04:05 etaletai13

do you know if it is possible to start the app on the actual chrome browser?

movingelectrons avatar May 06 '18 10:05 movingelectrons

I wanted to know if its easy to run it in a browser, or at very least the UI, so I can use the developer tools in chrome to tweak the css and html. Doing it that way will save me a good chunk of time for certain.

movingelectrons avatar May 06 '18 13:05 movingelectrons

@movingelectrons As far as I'm aware - for now - there's just the dev tools in the sdk version of nw.

etaletai13 avatar May 06 '18 14:05 etaletai13

Bumping up the bounty on this one to 30k MC for anyone that manages to get an integrated framework ready.

Varunram avatar Jun 24 '18 06:06 Varunram

Chai and Mocha, it'll do the job. I'll start finally.

etaletai13 avatar Sep 13 '18 21:09 etaletai13