MusicalNinjaDad
MusicalNinjaDad
Hi both, I see that you've suggested to remove the logging from `move_file`, mayeut, so this potentially loses importance.(?) But it's probably still a nice clean up, which I'd be...
I've made a suggestion of how we could approach this with the above PR. Would be interested in feedback from both of you on your thoughts ...
Thanks ... I just found that through my debugging too... Would it be useful to add a comment to that effect in the docs?
That makes sense. I can see how it would quickly become unwieldly to inline all the potential exceptions. How about adjusting the wording to: ```rst This method propagates any :exc:`OSError`...
On a more general note, as a user of pathlib; the real value in the Concrete Paths is the abstraction they provide over os specifics. This abstraction breaks relatively quickly...
@barneygale, don't worry about "flip-flopping". I often find it's the simple things that are actually hard because of how they slowly highlight subtle things as you work through them. That's...
Given what I just found in testing, I would suggest that treating `NotADirectoryError` and `FileNotFoundError` as equivalent is the right thing to do: Windows doesn't raise `NotADirectoryError`. That means that...
@barneygale - this is how `unlink` would/could work if it were to ignore `NotADirectoryError`. Semantically that makes success with `missing_ok = True` mean "The file is not there afterwards" and...
@barneygale - I was unexpectedly offline for the last 6 months due to illness. I've just pushed the changes you requested and will now start to merge into the lasted...
I have made the requested changes; please review again