MPD
MPD copied to clipboard
MusicPlayerDaemon
CD Audio Tags from Musicbrainz (working fork)
Feature request (not really)
I forked MPD and implemented cd audio tags from Musicbrainz.
I have no clue how pull requests work, and/or if I need to cleanup my code before hand.
Anyway here's what works: I got inspiration from Qobuz remote tags, but had to hook the RemoteTagCache system to disable it for this. With RemoteTagCache, cdda:///1 tags (for example) remain the same, regardless of other cd insertions. So the system caches the cd's tags in its class, locally, until the cd changes (and thus the cd musicbrainz id). I copied code from cd-discid to help me generate the musicbrainz id (it does not spin the cd drive for that). I used curl to fetch the info from musicbrainz. And upnp's ixml to parse the XML received.
Let me know if you're interested or not, and what I have to do moving forward
I have no idea what this feature means. If you want to get it merged, send a pull request (with a promise to keep maintaining it and handling bug reports), but be sure to submit a branch with proper commits. From a first glance, your branch looks quite messy, in serious need of cleanup. Code-wise, you should not be using the upnp ixml library, or else your feature will not work without upnp support - that makes no sense. MPD currently uses expat to parse XML - consider migrating to that one. Pull requests on GitHub are easy - click on "Pull requests" at the top, then on "New pull request". I'm sure you'll figure out the rest.
I guess I wasn't clear about the added feature.
Currently when you play an audio CD in MPD (through cd paranoia, by adding cdda:///x tracks), they are added with no tags. With this work I've done, the CD id in Musicbrainz' API format is generated and the CD's tags are fetched from the Musicbrainz server.
I'll get back to it this week-end, by creating a new branch and porting what I've done while cleaning it up. I'll also make the change from upnp to expat for XML. To be honest I used the first library I found in MPD for this and completelly missed the correct one. If all goes well, I'll issue a pull request.
Since you have closed your own PR https://github.com/MusicPlayerDaemon/MPD/pull/2301 I assume you have lost interest in the feature, therefore closing this feature request as well.