MPD icon indicating copy to clipboard operation
MPD copied to clipboard

android: Correctly move the libmpd.so output

Open DDRBoxman opened this issue 1 year ago • 1 comments

libmpd.so was getting written as a file called arm64-v8a instead of arm64-v8a/libmpd.so

DDRBoxman avatar Jan 18 '24 18:01 DDRBoxman

Is there really no way to do that natively with Meson, without resorting to a shell script? (And btw your shell script is unsafe .... it's the kind of awful shell script I want to avoid - shell is the worst of all programming languages.)

MaxKellermann avatar Jan 19 '24 09:01 MaxKellermann

No reply.

MaxKellermann avatar Mar 04 '24 17:03 MaxKellermann

Looking around I didn't find a way to have meson just move a file, not sure what the right fix is here.

DDRBoxman avatar Apr 07 '24 18:04 DDRBoxman

Maybe moving the file wasn't a good idea anyway, because moving an output file will cause it to be rebuilt; and copying files is something Meson can do: https://mesonbuild.com/Fs-module.html#copyfile

MaxKellermann avatar Apr 08 '24 07:04 MaxKellermann

Ah, nice I'll take a look at that, thanks!

DDRBoxman avatar Apr 08 '24 15:04 DDRBoxman

Hmm, looks like fs can't depend on other modules and is used to move stuff around for the build not after. I can at least redo the script in python so it's not bash.

DDRBoxman avatar Apr 08 '24 16:04 DDRBoxman