Gittyup icon indicating copy to clipboard operation
Gittyup copied to clipboard

Repo url that contain logins/password are considered malformed

Open Dronec opened this issue 2 years ago • 7 comments

Gettint the error like: Unable to fetch from 'origin' - malformed URL 'https://login:password@gitserver'

Expected behaviour:

Accept these urls.

Dronec avatar Jul 31 '23 21:07 Dronec

This comes from the libgit2 library, I have to check there. Is an @ allowed? Looks like a misc between http and ssh url

Murmele avatar Aug 03 '23 07:08 Murmele

I believe this is pretty standard in Git

Dronec avatar Aug 03 '23 07:08 Dronec

Can you try the build of this MR? https://github.com/Murmele/Gittyup/pull/153

Murmele avatar Aug 23 '23 14:08 Murmele

Can you try the build of this MR? #153

I'll need to setup the env and it'll take some time. By the way, I checked that the issue isn't in this format ('https://login:password@gitserver/') but in the space in the repo's name, i.e. https://login:password@gitserver/my%20repo

Dronec avatar Aug 30 '23 19:08 Dronec

You can just download the artifact from here: https://github.com/Murmele/Gittyup/actions/runs/5991400133?pr=153

Murmele avatar Aug 30 '23 20:08 Murmele

Looks like the Windows build failed

Dronec avatar Aug 30 '23 22:08 Dronec

I will check next days to get it work. Sorry

Murmele avatar Aug 31 '23 07:08 Murmele