Murmele
SEGV crash on refresh of remote accounts
Distribution: Flatpak Version: 1.2.0
I tried to refresh my remote account (private hosted gitlab) and gittyup crashed with a segmentation violation without any log message printed. It happened multiple times until i removed and readded the account. The animation that is shown on the remote account refresh has not started the times it crashed.
Sorry for that, @Murmele My name starts with a Zero :D
It is repruducable with my private gitlab account and my public github account every time i try, after i remove and readd the account i can refresh but after a restart of gittyup the crash is back.
overengineer sorry for disturbance. I will delete your comments so hopefully you don't get any notification anymore (I let the @ away to test if it is working) ^^
@Murmele Hey,
I fixed the crash by moving the clearRepos() call here https://github.com/Murmele/Gittyup/compare/master...0verEngineer:Gittyup:acc_refresh_crash
however there are still some problems:
- GitLab::host() method always returns "gitlab.com" but we are able to configure self hosted gitlab
- Account::password() does not get my password even if i pass the correct host url to the CredentialHelper, i did not check the CredentialHelper yet so i don't know how it works i have seen the libsecret type has been used in my case.
Am i missing some relevant infos here?
Hi @0verEngineer I hope to get to it next days then I can debug it and seing were the problem raises