Gittyup icon indicating copy to clipboard operation
Gittyup copied to clipboard

Untracked files shown in Staged TreeView

Open 0verEngineer opened this issue 3 years ago • 6 comments

I am using the Flatpak version 1.2.0 Files in an Untracked directory data are shown in the Staged TreeView. This happens with files where i have no permissions.

gittyup_bug gittyup_bug_files gittyup_bug_rights

0verEngineer avatar Dec 03 '22 14:12 0verEngineer

@Murmele I'm not sure if the flatpak label fits, I can try to reproduce the error without flatpak tomorrow

exactly-one-kas avatar Dec 05 '22 09:12 exactly-one-kas

@Murmele @exactly-one-kas It is indeed reproducible as non flatpak, just tried it. gittyup_bug_non_flatpak

0verEngineer avatar Dec 05 '22 10:12 0verEngineer

I will also have a look into.

In difftreemodel we are using the stageState to determine if staged or not staged. Maybe we can have a look into which value it returns.

Can you try once with the latest release. There we changed the behaviour, but normaly they are shown in the staged and unstaged section and not only in the staged section const auto state = node->stageState(index, Node::ParentStageState::Any);

Murmele avatar Dec 05 '22 11:12 Murmele

In the current (1.2.0) flatpak release and master it's only shown in the staged view

0verEngineer avatar Dec 05 '22 14:12 0verEngineer

@0verEngineer can you try again with 1.2.2?

https://github.com/Murmele/Gittyup/pull/368

Murmele avatar Jan 27 '23 08:01 Murmele

@Murmele Sorry i completely forgot about this, still happens on 1.3.0 It is easily testable with a file owned by another user with following perms: -rwx------

0verEngineer avatar Aug 11 '23 20:08 0verEngineer