Gittyup implement keypress otherwise a segfault occurs

potential fix of #109

Use the procedure in #109 to reproduce the segfault

fix occurs also in 96c2fb50778da0ffcbad95ed59572299508773a8

Jun 02 '22 13:06 Murmele

My quick-fix:

Segfault

Jun 04 '22 14:06 stefanknotzer

hmm I have to check, because I did not see the problem at this assert. For me it seems to be an assert in the qt lib I debugged already a little bit by reimplementing parent() in the TreeProxy to check the index of the item and it seems that this is because for some reason the element the QModelIndex points is anymore available

Jun 05 '22 15:06 Murmele

@stefanknotzer can you try with the repository I posted in #109 if you get the segfault at the same position than me. Maybe we have multiple bugs here

Jun 08 '22 07:06 Murmele

I was able to build 96c2fb50778da0ffcbad95ed59572299508773a8 but I can't reproduce the segfault any more

Jun 09 '22 16:06 stefanknotzer

On which operating system?

Jun 10 '22 07:06 Murmele

Windows 10 and openSUSE LEAP 15.3. Is the problem caused by a race condition? Then the Qt Version / gcc version / Visual Studio version could make a difference.

Jun 10 '22 15:06 stefanknotzer

Windows 10 and openSUSE LEAP 15.3. Is the problem caused by a race condition? Then the Qt Version / gcc version / Visual Studio version could make a difference.

I tested it on Windows 10 with Qt 5.15.2 MinGW 64-bit commit: 96c2fb50778da0ffcbad95ed59572299508773a8

@stefanknotzer have you tried it with the test repo in #109 ?

Jun 13 '22 11:06 Murmele

Windows 10, Qt 5.15.0, MSVC2019 64Bit: no segfault with the test repo from #109

Jun 19 '22 09:06 stefanknotzer

I tested it on Linux Debug with Qt5.15.5 and it is still reproducable (4a095573095423a046e6542528632297fbc52a9e)

Aug 12 '22 14:08 Murmele

@exactly-one-kas from my side we can merge it, because I am still able to reproduce the issue and this solves the issue. Do you have any concerns?

Aug 12 '22 14:08 Murmele