ngx-sharebuttons icon indicating copy to clipboard operation
ngx-sharebuttons copied to clipboard

Tweniee:#650 Added X Twitter icon

Open Tweniee opened this issue 1 year ago • 10 comments

@MurhafSousli Please can you review #650 image

Tweniee avatar Nov 24 '23 10:11 Tweniee

Any idea when the pull request will be reviewed?

mikecci avatar Dec 07 '23 14:12 mikecci

@MurhafSousli

mikecci avatar Dec 14 '23 11:12 mikecci

@mikecci Why don't we just change the existing twitter button icon?

MurhafSousli avatar Dec 14 '23 18:12 MurhafSousli

@mikecci Why don't we just change the existing twitter button icon?

It good to have options and diversity

Tweniee avatar Dec 15 '23 06:12 Tweniee

@Tweniee I don't think users would use the old twitter icon when the new one is available!

MurhafSousli avatar Dec 15 '23 12:12 MurhafSousli

@MurhafSousli I believe there should be an option for end users to choose their preferred icon. This way, users can align the icon with their chosen theme. Many web apps currently use the old logo to match their themes, and newly created logos can be applied to new web apps also.

Tweniee avatar Dec 15 '23 12:12 Tweniee

@Tweniee Users might not opt for the old Twitter icon if the new one is accessible!

I share your perspective, but I believe there should be room for flexibility without removing already established logos. For instance, the IRCTC website, which handles a significant database, continues to use the old bird logo from Twitter as an example.

Screenshot Capture - 2023-12-15 - 18-30-17

Tweniee avatar Dec 15 '23 13:12 Tweniee

Hello Friends, I would like to know when are you planning to merge this pull request and publish a new version of library?

AshotAleqsanyan96 avatar Jan 11 '24 06:01 AshotAleqsanyan96

I cannot merge this PR, I requested a change, we don't want 2 twitter buttons with different icons, users can always change the icon of the button if they like, but we should not have two duplicated buttons with only icon difference.

MurhafSousli avatar Jan 11 '24 15:01 MurhafSousli

@MurhafSousli thank you very much for the quick reply and clarification. yeah we will process with your suggestion

AshotAleqsanyan96 avatar Jan 11 '24 16:01 AshotAleqsanyan96

This is fixed in v14 beta

MurhafSousli avatar May 24 '24 02:05 MurhafSousli