ngx-sharebuttons
ngx-sharebuttons copied to clipboard
Tweniee:#650 Added X Twitter icon
@MurhafSousli Please can you review #650
Any idea when the pull request will be reviewed?
@MurhafSousli
@mikecci Why don't we just change the existing twitter button icon?
@mikecci Why don't we just change the existing twitter button icon?
It good to have options and diversity
@Tweniee I don't think users would use the old twitter icon when the new one is available!
@MurhafSousli I believe there should be an option for end users to choose their preferred icon. This way, users can align the icon with their chosen theme. Many web apps currently use the old logo to match their themes, and newly created logos can be applied to new web apps also.
@Tweniee Users might not opt for the old Twitter icon if the new one is accessible!
I share your perspective, but I believe there should be room for flexibility without removing already established logos. For instance, the IRCTC website, which handles a significant database, continues to use the old bird logo from Twitter as an example.
Hello Friends, I would like to know when are you planning to merge this pull request and publish a new version of library?
I cannot merge this PR, I requested a change, we don't want 2 twitter buttons with different icons, users can always change the icon of the button if they like, but we should not have two duplicated buttons with only icon difference.
@MurhafSousli thank you very much for the quick reply and clarification. yeah we will process with your suggestion
This is fixed in v14 beta