Merlijn Vos

Results 195 comments of Merlijn Vos

I agree with your feedback on state. This is something I struggled with, how to separate state management. I'll try to think about that again and then we can reevaluate.

Update: I strictly separated the logic from the side-effects and only `getOpts` is passed to the class, which I think is reasonable and makes sense. However, as running/cancelling/retrying upload is...

I understand your concerns. First, consider my last comment: > Lastly, going deeper in core made it clear to me that almost everything we do is in fact just getting...

To make this actionable: 1. Idea is to extend the existing `upload-progress` event in core, which is currently just calculating progress, to also add a timeout there. https://github.com/transloadit/uppy/blob/master/packages/@uppy/core/src/index.js#L1140 2. `this.uppy.emit('upload-progress',...

At least with local files it's possible with [`FileSystemEntry`](https://developer.mozilla.org/en-US/docs/Web/API/FileSystemEntry): ```js uppy.addFile({ name: 'my-file.jpg', // file name type: 'image/jpeg', // file type data: blob, // file blob meta: { // optional,...

@tokidoki11 @Chris1234567899 would you be willing to create a PR for it?

Added the credentials as secrets

Added the multipart cors settings, should maybe play locally to find something that works for both

It think it's important to test this functionality too: https://github.com/transloadit/uppy/pull/3955

Works locally for me 😭