InvMenu icon indicating copy to clipboard operation
InvMenu copied to clipboard

Minecart chest stuff

Open dadodasyra opened this issue 2 years ago • 3 comments

Why aren't we using entity inventories like minecraft chest ? This can be more user friendly to avoid spawning a "fake" chest block we can spawn an invisible custom entity with the same components as minecart chests.

This may lead to features like custom inventory sizes too. https://github.com/tedo0627/InventoryUI is a good starting point

dadodasyra avatar Sep 10 '23 22:09 dadodasyra

Preference towards block-backed inventories over entity-backed inventories has been discussed in https://github.com/Muqsit/InvMenu/issues/144#issuecomment-1436693452. Custom-sized inventories using tedo0627/InventoryUI has been discussed in https://github.com/Muqsit/InvMenu/issues/201#issuecomment-1606110331.

Muqsit avatar Sep 10 '23 22:09 Muqsit

Preference towards block-backed inventories over entity-backed inventories has been discussed in #144 (comment). Custom-sized inventories using tedo0627/InventoryUI has been discussed in #201 (comment).

interesting, therefore I don't think protocol changes are really a big deal, as invmenu is easy to update for developers I guess it's interesting to still keep an eye on this possibility. https://github.com/Muqsit/CustomSizedInvMenu should be featured maybe in the ReadMe

dadodasyra avatar Sep 12 '23 12:09 dadodasyra

interesting, therefore I don't think protocol changes are really a big deal, as invmenu is easy to update for developers I guess it's interesting to still keep an eye on this possibility. https://github.com/Muqsit/CustomSizedInvMenu should be featured maybe in the ReadMe

Looking back at #144, AddActorPacket is already in use by ActorInvMenuGraphic, so there is no added maintenance overhead anymore. Actor-backed inventories can be substituted for block-backed ones, however InvMenu::TYPE_DOUBLE_CHEST would be using a block-backed inventory since no entity inventories feature a 54-slot storage.

Muqsit avatar Sep 12 '23 14:09 Muqsit