AppManager icon indicating copy to clipboard operation
AppManager copied to clipboard
verified publisher icon MuntashirAkon

Not following Material You accent in pitch black mode

Open assembleDebug opened this issue 3 years ago • 4 comments

  • [x] I know what my device, OS and App Manager versions are
  • [x] I know how to take logs
  • [x] I know how to reproduce the issue which may not be specific to my device

Describe the bug I don't know if this is intentional behaviour. App Manager doesn't seem to follow material you accent colors (for toggles and other things) when using the pitch black mode. Even in "Day" mode, if you turn on pitch black mode, the accent/background changes to some pre-default colors or something. see screenshot.

To Reproduce Steps to reproduce the behaviour:

  1. Go to settings
  2. Click on turn on pitch black mode
  3. See the colors changed automatically

Expected behavior Should follow the material you colors on supported devices.

Screenshots Screenshot_20220720-081408.png Screenshot_20220720-081404.png

The first image is with Pitch black option turned on. The second with pitch black mode turned off.

Device info

  • Device: Note 10 Pro
  • OS Version: 12.1/L
  • App Manager Version: Debug #1906
  • Mode: root

assembleDebug avatar Jul 20 '22 02:07 assembleDebug

Hmm, I've probably skipped some docs regarding M3. Let me review the docs to see what I did wrong.

MuntashirAkon avatar Jul 22 '22 11:07 MuntashirAkon

Google is yet to release an Google API-less version of Sv2 (Android 12L) iso file for the emulator (Android 12 emulator version does not support Material You). So, I cannot test it for now.

MuntashirAkon avatar Sep 11 '22 06:09 MuntashirAkon

Check 47931efa1a865fb7174193df45d3181ca0c3a169. (Highly unlikely that the issue will be resolved but just in case.)

MuntashirAkon avatar Sep 11 '22 12:09 MuntashirAkon

Check 47931ef. (Highly unlikely that the issue will be resolved but just in case.)

The issue is still there. :-|

assembleDebug avatar Sep 13 '22 05:09 assembleDebug

Please check 0e02b44ffbaa762d22fa0a9d0cb43cebf3c7eaa7. (I still can't check as I don't have access to an OS that support dynamic colours.)

MuntashirAkon avatar Feb 16 '23 16:02 MuntashirAkon

Please check 0e02b44. (I still can't check as I don't have access to an OS that support dynamic colours.)

Seems working. But because of material you elements it's not completely possible to have pitch black everywhere, that's completely understandable. There seems to be a little issue, when we switch the pure black theme toggle, it automatically send me back to previous page (the main settings page). Everything else seems okay. Screenshot_20230217-193242_AM Debug Screenshot_20230217-193214_AM Debug Screenshot_20230217-193204_AM Debug

assembleDebug avatar Feb 17 '23 14:02 assembleDebug

Hmm, there seems to be some sort of elevation present there.

But because of material you elements it's not completely possible to have pitch black everywhere, that's completely understandable.

An option could be added to disable dynamic colouring, too.

MuntashirAkon avatar Feb 17 '23 16:02 MuntashirAkon

Fixed in 87f4a00d575313a3f62f4cbce60bf0b15e9eb113

MuntashirAkon avatar Jan 28 '24 11:01 MuntashirAkon