Philip Munksgaard comments

Results 119 comments of


                                            Philip Munksgaard

Add DB_URL_FILE and DB_PASSWORD_FILE

I am unsure if I should add similar functionality for PGA_API_KEY. I'm guessing this is considered sensitive information as well, but the logic around loading PGA_API_KEY seems a bit more...

Add DB_URL_FILE and DB_PASSWORD_FILE

Hi @msakrejda! These are all good questions, which I don't think I'm necessarily the right person to answer, but I'll give it a shot. To preface, I'll say that I...

elixir: Initial commit

Thanks @elliotblackburn! I spent way too much time scratching this particular itch, but it was nice to finally get something working. I would very much appreciate if you could try...

gen_tcp:listen doesn't allow overwriting tcp_backend if `:inet` is passed

Thank you!

Apply filter to float_with_bounds

> This doesn't affect "normal" use cases where the range is much smaller, right? (Given the issue only appears with large numbers) This happens because floats lose precision at $2^{53}$....

Apply filter to float_with_bounds

I've updated the PR to make it more likely that the special cases are hit in tests. Hopefully that should help fix the coveralls regression.

Make it clear that the `phoenix_html_helpers` library is needed to use `polymorphic_embed_inputs_for`

Out of curiosity, why is `phoenix_html_helpers` necessary? Would it be possible to fix this library such that it doesn't depend on `phoenix_html_helpers`?

feat: Add support for StreamData generators

Hi @ibarchenkov, you're very welcome! Thanks for doing the hard initial work. Good question. Would that mean that users would have to choose which "strategy" to use? E.g. if I...

Stubbing a Req.Request in a Phoenix.LiveView.assign_async

For me, the problem was that my stub was defined before the `render_async` but after the `live` call, like this: ```elixir defmodule DemoLiveTest do use ExUnit.Case use PhoenixPlayground.Test, live: DemoLive...