Multiverse-NetherPortals nether and end portals related advancement not triggered

Information

Server version: tested on 1.14, 1.15 and 1.16
Full output of /mv version -b: https://j.mp/30BPzZM

Details

I was able to reproduce my issue on a freshly setup and up-to-date server with the latest version of Multiverse plugins with no other plugins and with no kinds of other server or client mods.

Description
"We Need to Go Deeper" advancement not triggered when enter Nether Portal as well as "The End?" for end portals, when portals are made on the non-default world. Probably the way mv-np handles nether portals not compatible with vanilla advancement checking. My draft solution is to manually add to player on EntityEnterPortalEvent.

Oct 05 '20 07:10 benwoo1110

I think this should be handled by the server, not by us.

Feb 09 '21 06:02 nicegamer7

Thinking of it yea, maybe we should contact paper/spigot on it.

Feb 09 '21 06:02 benwoo1110

Yeah, I'm about to take a look and see how easy it is, then gonna report to Spigot.

Feb 09 '21 06:02 nicegamer7

Looks like it's handled by the client :/

I guess it's up to us.

edit: Should be easy though. I'll open a PR tomorrow, or if you wanna do it go ahead.

Feb 09 '21 07:02 nicegamer7

edit: Should be easy though. I'll open a PR tomorrow, or if you wanna do it go ahead.

Haha didn't see your edit, so when ahead and opened a PR for it already. #218

Feb 09 '21 09:02 benwoo1110

No worries, I'll take a look.

Feb 09 '21 19:02 nicegamer7

It turns out the server CAN trigger these. I'm gonna open a ticket with Spigot.

edit: Yup, I just got it working.

Feb 11 '21 16:02 nicegamer7

My memory is really bad... did I end up finishing this?

Apr 24 '21 19:04 nicegamer7

I did not. Opening a PR now.

Apr 24 '21 20:04 nicegamer7

Didn’t I fix it here? https://github.com/Multiverse/Multiverse-NetherPortals/pull/218

Apr 25 '21 01:04 benwoo1110

Yeah, but it's cleaner for the server to handle this, so I submitted a PR to Spigot. If it gets merged, then in MV5 we can remove the check in MVNP.

Apr 25 '21 01:04 nicegamer7

Ah, it may be worth checking whether other nether related advancement are not triggered as well? There is one called “Subspace Bubble”, not sure if this also will be not detected, since entering nether portal isn’t detected.

“”Use the Nether to travel between 2 points in the Overworld with a minimum horizontal distance of 7000 blocks between each other, 875 blocks in the Nether.“”

Apr 25 '21 01:04 benwoo1110

Let me see if that's fixed lol.

Apr 25 '21 01:04 nicegamer7

Without either of our changes, unsurprisingly, it doesn't work.

With only your change, it doesn't work.

With only the server change I made, it works :D

Apr 25 '21 01:04 nicegamer7

👍

Apr 25 '21 01:04 benwoo1110

Okay, the PR went through, so this is no longer necessary for us to do in 1.16.5+.

I think it's okay to keep the stuff you added in #218, but we should make it only for versions before 1.16.5.

May 15 '21 01:05 nicegamer7