MultiQC icon indicating copy to clipboard operation
MultiQC copied to clipboard

New module: Checkatlas

Open drbecavin opened this issue 2 years ago • 2 comments

[NEW MODULE] This comment contains a description of changes (with reason)

  • [x] CHANGELOG.md has been updated
  • [x] (push last thursday)] There is example tool output for tools in the https://github.com/ewels/MultiQC_TestData repository or attached to this PR
  • [x] Code is tested and works locally (including with --lint flag)
  • [ ] NO (do not understand what to do ?) docs/README.md is updated with link to below
  • [x] docs/modulename.md is created
  • [x] Everything that can be represented with a plot instead of a table is a plot
  • [x] Report sections have a description and help text (with self.add_section)
  • [x] There aren't any huge tables with > 6 columns (explain reasoning if so)
  • [x] Each table column has a different colour scale to its neighbour, which relates to the data (eg. if high numbers are bad, they're red)
  • [x] Module does not do any significant computational work

drbecavin avatar Jun 23 '22 12:06 drbecavin

New pre-commit tests are failing. I can't push changes to your fork for you, so can't fix for you sorry. To do so (within the MultiQC repo directory):

pip install pre-commit
pre-commit install
pre-commit run --all-files

ewels avatar Jan 20 '23 22:01 ewels

I tried running the code on the test data, but the report is very broken: multiqc_report.html

General Stats table is broken: image

Sections and plots are empty: image

Please make sure that the code works with the test data and let me know when the module is ready for review 👍🏻

Shout if you need any help!

Phil

ewels avatar Jan 20 '23 22:01 ewels