multimc-pkgbuild Move the icon of .desktop file so it can be themed

Currently the MultiMC icon is placed in /opt/multimc/, and the .desktop file points to it directly. Because of that icon themes are unable to theme MMC, making it stand out in the application launcher. This PR moves the icon over to ~~/usr/share/icons/hicolor/scalable/apps/~~ /usr/share/pixmaps/ and a patch is applied to the .desktop file to point to multimc icon. This way, if a user wishes to use a theme including an icon for MMC, the theme will be picked up; otherwise it'll fall back to the bundled icon.

Oct 22 '24 18:10 TechniKris

Neat. Maybe I should apply this to the debian package and then we don't have to do it here.

Dec 22 '24 03:12 peterix

That'd probably be ideal, I thought patching the PKGBUILD would be the simplest way 😅; although I guess the PKGBUILD would still need to be adjusted after the .deb update.

Also, since I made this PR I realized the /usr/share/icons/ path actually depends on a variable $XDG_DATA_DIRS (as per https://specifications.freedesktop.org/icon-theme-spec/latest/#directory_layout ) and I'm not entirely confident about handling envvars; so I updated it to /usr/share/pixmaps/ which seems to be static. Feel free to use whichever one you'd like though.

Dec 22 '24 13:12 TechniKris

Merging https://github.com/MultiMC/Launcher/pull/4971 should apply this change to the Debian package.

Jan 28 '25 15:01 TechniKris