Launcher CMake: Require and use Java 1.8

The specific version is mentioned in the build instructions at: https://github.com/MultiMC/Launcher/blob/abc582466ee7a88a398604c11b8ccb6be424c1fe/BUILD.md

Without this patch compilation fails because target and source have a minimum value of 8.

Aug 08 '25 00:08 davidebeatrici

I just realized there is an identical commit in PolyMC: https://github.com/PolyMC/PolyMC/commit/8e842d1b6e695f714c8fcb43270e7545b400b68f

Aug 17 '25 19:08 davidebeatrici

why would you want to drop support for java 7? theres plenty of old mods that do not work on java 8

Aug 18 '25 07:08 phit

why would you want to drop support for java 7? theres plenty of old mods that do not work on java 8

If I may ask, which mods for example?

Aug 18 '25 12:08 Moresteck

As for the PR, I agree using Java 8 for building would make the process easier, but I don't see why source and target versions should get bumped from 7 to 8. The source is still compatible with Java 7. I'd suggest them to be left at 7 for both NewLaunch.jar and JavaCheck.jar.

Aug 18 '25 17:08 Moresteck

The problem is that recent OpenJDK versions support a minimum version of 8.

Aug 23 '25 01:08 davidebeatrici

The problem is that recent OpenJDK versions support a minimum version of 8.

But you'd be using JDK 8 to build MultiMC, no? At least that's what I would do.

Aug 23 '25 06:08 Moresteck

Yes, OpenJDK 8 is still supported. If you all agree I will drop the source and target changes.

Aug 23 '25 10:08 davidebeatrici