Launcher icon indicating copy to clipboard operation
Launcher copied to clipboard

Fixed Wrong Proxy Settings Message

Open 0xIO32 opened this issue 2 years ago • 8 comments

image It says "Minecraft does not accept proxy settings.", but thats wrong: image (Decompiled 1.20.1 using jd-gui)

0xIO32 avatar Sep 04 '23 19:09 0xIO32

iirc, it just doesn't do anything with em.

Zetabite avatar Sep 04 '23 19:09 Zetabite

Let me verify that

0xIO32 avatar Sep 04 '23 19:09 0xIO32

It does use it for authentication: image image

0xIO32 avatar Sep 04 '23 19:09 0xIO32

That isn't MultiMC in the screenshot

arthomnix avatar Sep 04 '23 19:09 arthomnix

It's a fork of it and its the same on MultiMC: image

0xIO32 avatar Sep 04 '23 19:09 0xIO32

I don't think this is particularly interesting to change. It is not used to play the game. It also doesn't apply to all game versions.

peterix avatar Sep 05 '23 13:09 peterix

Like yeah, we can change the string... But I'd rather do something more substantial. Like encode which versions actually take these args in metadata.

peterix avatar Sep 05 '23 13:09 peterix

I don't think this is particularly interesting to change. It is not used to play the game. It also doesn't apply to all game versions.

Yes, but it technically spreads misinformation. Maybe i will create a pr (or an issue, i never coded with c++...) to add it to metadata and create an entry in the installation config for passing proxy arguments 🤔. But for now the string annoys me.

0xIO32 avatar Sep 08 '23 23:09 0xIO32