Launcher icon indicating copy to clipboard operation
Launcher copied to clipboard

Settings wont translate if the settings window is already open.

Open PMorghK opened this issue 3 years ago • 1 comments

Operating System

Windows, Linux

Description of bug

basically the settings window wont full translate after just clicking on a different language. you would have to close the window and reopen it to make the changes.

(also I couldn't really find a good title for it :P)

side bug : () apparently the phrases close, Help and Launcher are not translated. the problem is that I couldn't find the same phrases in crowdin to translate them and if I did, they where already translated)

Steps to reproduce

simply change the language (NOTE : don't close the settings menu)

the example here is changing from the English language to Farsi:

Screenshot from 2022-02-22 15-42-34

changed to farsi: Screenshot from 2022-02-22 15-44-31

now click on a different tab of the settings menu.

Screenshot from 2022-02-22 15-45-45

as you can see. the settings are not translated.

you can fix this by closing and reopening the settings window or by closing and reopening the application.

Screenshot from 2022-02-22 15-47-22

Suspected cause

well I'm thinking its because the code is not reloaded after the change which makes sense. you really don't need all the code running and waiting for a reload.

This issue is unique

  • [X] I have searched the issue tracker and did not find an issue describing my bug.

PMorghK avatar Feb 22 '22 12:02 PMorghK

previously https://github.com/MultiMC/Launcher/issues/3719

phit avatar Feb 22 '22 12:02 phit