Launcher icon indicating copy to clipboard operation
Launcher copied to clipboard

Relative JRE paths don’t work

Open ryleu opened this issue 3 years ago • 6 comments

Operating System

Windows

Description of bug

If you use a relative path for the JRE location, Minecraft does not launch.

Steps to reproduce

  • Place the jre folder from wherever you get your JRE in the same folder that MMC is in.
  • Set the Java path in MMC to ../jre/bin/javaw.exe.
  • Try to launch the game.

Suspected cause

MultiMC doesn’t resolve relative paths before attempting to launch the game with them.

Possible solution: resolve relative paths before attempting to run the game. Ideally resolve them relative to the MultiMC executable.

This issue is unique

  • [X] I have searched the issue tracker and did not find an issue describing my bug.

ryleu avatar Dec 25 '21 21:12 ryleu

This seems like it'd be hard to get right, especially if there were symlinks involved. IMO this is a feature request, not a bug.

embeddedt avatar Dec 28 '21 02:12 embeddedt

This seems like it'd be hard to get right, especially if there were symlinks involved.

It could be. I believe that, at least on Linux, there's a command to resolve paths.

IMO this is a feature request, not a bug.

I thought it fit as a BR, because I was expecting it to work and it didn't. I wouldn't mind it being re-tagged as an FR.

ryleu avatar Dec 28 '21 02:12 ryleu

this works already on Windows, are you sure it doesn't on Linux? image

can you provide your launcher log file, MultiMC-0.log in the launcher folder

phit avatar Dec 28 '21 08:12 phit

It definitely doesn't work on Windows. Let me get you a log. I don't have a Windows machine though, I'm making this for a friend who does, so it might be a sec. I'll test it on Linux too though.

ryleu avatar Dec 28 '21 13:12 ryleu

Place the jre folder from wherever you get your JRE in the same folder that MMC is in.

This is how https://github.com/MultiMC/Launcher/wiki/Unsupported-Intel-GPUs is done.

It definitely doesn't work on Windows.

Incorrect.

I know for a fact it does. I was visiting family during new years and did https://github.com/MultiMC/Launcher/wiki/Unsupported-Intel-GPUs for my neice toaster laptop and it definitely worked.

And on linux; Screenshot_20220116_224543

PEBKAC

spannerman79 avatar Jan 16 '22 11:01 spannerman79

I know for a fact it does. I was visiting family during new years and did https://github.com/MultiMC/Launcher/wiki/Unsupported-Intel-GPUs for my neice toaster laptop and it definitely worked.

Maybe it's the ../ I used?

ryleu avatar Jan 16 '22 16:01 ryleu

Try to write down the path by yourself @ryleu

fixed now, not sure how or why. i didn't change the path, but the error is gone.

ryleu avatar Aug 12 '23 21:08 ryleu