Importing MultiMC instances with icons with the same names as built in icons overrides built in icons

[kb-1000]

System Information

MultiMC version: 0.6.12-develop-1434

Operating System: Windows 10 1909

Summary of the issue or suggestion:

What should happen:

The instance should get imported, with the icon in its ZIP, but not change the icons of other instances.

Steps to reproduce the issue (Add more if needed):

1. Create instance with MultiMC infinity icon

2. Import ScottoMotto's https://www.mediafire.com/file/mw8vl1txt7fkg1i/20w14Infinite_Fabric.zip/file

Suspected cause:

Logs/Screenshots:

Additional Info:

[Merith-TK]

Since my issue was closed as it was a duplicate

possible fix for this, if $INST_DIR contains <iconKey>.png/jpg/jpeg display that icon, rather than updating the global index of icons (or whatever it is called instead)

[Zetabite]

From what i read in the code, overwriting the builtin ones is intended

[kb-1000]

I don't agree here... sure, it's probably intended that you as the user can override them. But do you really want that importing some random instance that someone with such a setup exported to overwrite the icon of all existing instances that use it? I don't. I had that happen with an instance replacing the infinity icon once.

[kb-1000]

reading up, that's actually what made me create this issue

[Zetabite]

well, with my suggested PR, there would most likely, no longer be overwritten icons, unless you actively rename the icon