Mugurell
Mugurell
And here https://github.com/mozilla-mobile/fenix/pull/26431
Failed again in https://github.com/mozilla-mobile/fenix/pull/26436 Seems like something regressed.
Will look into fixing or disabling.
According to [Glean documentation](https://mozilla.github.io/glean/book/reference/metrics/timing_distribution.html) `invalid_state` is recorded if a non-existing/stopped timer is stopped again. We are not directly calling start/stop but just [`accumulateSamples`](https://github.com/mozilla-mobile/fenix/blob/bbf2d427d2f7191d245c8dcc295699fc7512a0d5/app/src/main/java/org/mozilla/fenix/telemetry/TelemetryMiddleware.kt#L108-L112) which has little documentation about how it...
> Can a reviewer tell me if this is a correct way to introduce new strings ? As both chats fenix an l10n in chat.mozilla.org couldn't tell me if I...
> Ok, so I should only set in `values/strings.xml` wait this string is imported in l10n, copy values on Pontoon from desktop to fenix and wait auto import here ?...
> Should I wait the implementation of api and resolution in `lib.rs` or goes for `bookmarks_get_tree` for now, and evolve to new api later ? > > I'm afraid that...
> I'm not sure to understand what you expect. Can you precise a quick example ? I tried todo micro commit as requested in `contribution.md`. Do you want something like...
Thank you for pushing through @Taknok ! Tested it a bit manually and it works beautifully, seems like just some tests need to be updated and then do a quick...
Seen again in https://github.com/mozilla-mobile/fenix/pull/26431 > java.lang.AssertionError: label: cold_unknown expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.mozilla.fenix.perf.StartupTypeTelemetryTest.GIVEN all possible path and state combinations WHEN record telemetry THEN the...