Michael Herzog

Results 352 comments of Michael Herzog

How about using `r141` as the target release? A soon as this PR is merged at the end of next week, I'll make the next one and rename `Texture.encoding` to...

Yes, the constants should be changed too. But it's sufficient to note this at #23614. Please let's keep the discussion focused on what the PR is about. Renaming `WebGLRenderer.outputEncoding`.

> I can't tell if you're saying we should wait to replace the constants until a different release or a different PR. Different PR. Otherwise the PRs are going to...

> I'll just not here as I have in other issues that naming this field something like canvasColorSpace could be more clear. I think it's best if @mrdoob makes a...

> that it is ignored if writing to canvas comes at the end of a post-processing chain `WebGLRenderer.outputEncoding` triggers _the color space conversion in GLSL shaders_. That only works for...

Okay, then I change my vote back to `outputColorSpace` 😇 .

> If scene.background were a cubemap, could/should that be used instead? That would work, too. > I might suggest naming this parameter blur instead of blurriness. Easier to remember, and...

Updated the PR as suggested and marked it as "Ready for Review".

Sounds good! Let me update the PR.

@mrdoob Would you be more comfortable with merging this PR if I give `TextureBackground` a shot? 😇 Regarding #17420, do we need the distinction between `TextureBackground` and `CubeTextureBackground`? It seems...