Michael Herzog

Results 352 comments of Michael Herzog

This is not the first time devs come up with such a feature request since not everybody is happy with the gizmos, see #22045. Maybe we should try to find...

There is the following guide with some basic information about contributing: https://github.com/mrdoob/three.js/blob/dev/.github/CONTRIBUTING.md As soon as you have opened your PR, I start with the review process.

> under certain circumstances, entering an XR session can result in the cameras being non-decomposable for a frame or two (for reasons not entirely clear to me, randomly happens with...

Some thinking about this: The [glTF spec](https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#transformations) says transformation matrices must be decomposable to TRS properties. Transformation matrices cannot skew or shear. https://github.com/gltf-rs/gltf/issues/21#issuecomment-325210103 says a 4x4 matrix is decomposable if...

> nested hierarchies can easily end up with non-decomposable world matrices. How can that happen if all world matrices in the hierarchy are proper decomposable?

We can documented a minimum texture size of 64x64 in the documentation page: https://threejs.org/docs/index.html#api/en/extras/PMREMGenerator I agree if the code complexity isn't worth it, let's consider this as a known limitation....

Side note: It's right that for classic environment/reflection mapping you usually go for larger texture sizes. However, there is at least on valid exception: Irradiance environment maps (or diffuse environment...

> Creating a small map on the fly is useful when generating basic, soft gradient lighting. @gkjohnson Given this use case, could you use a light probe instead? I have...

@WestLangley Would you like to make a PR that adds your text to the descriptions of `fromEquirectangular()` and `fromCubemap()`? I'm undecided about the warning though since we normally do not...

> If the scene tree has been "ordered" in a specific way, doesn't it make sense to have the option to stop everything on first hit ? This could a...