Mudlet icon indicating copy to clipboard operation
Mudlet copied to clipboard

Infrastructure: update minimum cmake to 3.25.1

Open vadi2 opened this issue 1 year ago • 3 comments

Brief overview of PR changes/additions

Update minimum cmake to 3.25.1, which is the highest available version in Debian stable: https://packages.debian.org/stable/cmake

Motivation for adding to Mudlet

Open the door to modernizing our cmake files and reducing complexity within them.

Other info (issues closed, discussion etc)

See https://hsf-training.github.io/hsf-training-cmake-webpage/aio/index.html, https://cliutils.gitlab.io/modern-cmake on how modern cmake should be done.

vadi2 avatar Jun 24 '24 06:06 vadi2

Hey there! Thanks for helping Mudlet improve. :star2:

Test versions

You can directly test the changes here:

  • linux: https://make.mudlet.org/snapshots/2a75d9/Mudlet-4.18.5-testing-pr7287-41251fbe-linux-x64.AppImage.tar (commit 41251fbe)
  • osx: https://make.mudlet.org/snapshots/89137e/Mudlet-4.18.5-testing-pr7287-a47b4693-x86_64.dmg (commit a47b4693)
  • windows 64 bit: https://make.mudlet.org/snapshots/175f60/Mudlet-4.18.5-testing-pr7287-a47b4693-windows-64.zip (commit a47b4693)
  • windows 32 bit: https://make.mudlet.org/snapshots/fc9907/Mudlet-4.18.5-testing-pr7287-a47b4693-windows-32.zip (commit a47b4693)

No need to install anything - just unzip and run. Let us know if it works well, and if it doesn't, please give details.

Looks like a CMake too far - elsewhere I hit up a recommendation (from CMake 3.29.x) to set a minimum of 3.5.0 IIRC - and some of the build jobs are borking because they are using 3.20.1. 🤷‍♂️

SlySven avatar Jun 24 '24 16:06 SlySven

That is because at the moment we explicitly install cmake 3.20.1: https://github.com/Mudlet/Mudlet/blob/development/.github/workflows/build-mudlet.yml#L89-L91

vadi2 avatar Jun 24 '24 18:06 vadi2

Just for the record I can confirm that Devuan 5 (equivalent to Debian 12) is providing CMake version 3.25.1). FreeBSD is at least 3.30.5 for top tier processors (i386, amd64, arm7, aarch64).

However something looks broken in the MacOS (arm64) build: image

leading, I think, to this: image

SlySven avatar Dec 25 '24 13:12 SlySven

It was a transient error on the part of Apple's infrastructure, re-running the build a few times worked.

vadi2 avatar Dec 25 '24 14:12 vadi2