Mudlet icon indicating copy to clipboard operation
Mudlet copied to clipboard

Replace `gon` with another tool to notarize macOS builds with

Open vadi2 opened this issue 1 year ago • 10 comments

Brief summary of issue / Description of requested feature:

Replace https://github.com/mitchellh/gon with another tool to notarize our macOS builds with, as the former is no longer working or maintained (logs).

Steps to reproduce the issue / Reasons for adding feature:

  1. So we can continue to sign release builds of Mudlet

Error output / Expected result of feature

sign_and_notarize function is able to notarize Mudlet binaries again.

Extra information, such as the Mudlet version, operating system and ideas for how to solve / implement:

Example of how other repositories solved this issue: https://github.com/confluentinc/cli/pull/2346/files

vadi2 avatar Jun 22 '24 07:06 vadi2

/bounty $50

vadi2 avatar Jun 23 '24 02:06 vadi2

💎 $200 bounty • Mudlet

~~## 💎 $200 bounty • Mudlet~~

🔨 See instructions for compiling Mudlet

Steps to solve:

  1. Start working: Comment /attempt #7278
  2. Submit work: Create a pull request including /claim #7278 in the PR body to claim the bounty
  3. Attach proof: Include a screencast in the PR that fully tests the new functionality
  4. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to Mudlet/Mudlet!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @unworld11 Jun 24, 2024, 9:25:53 AM WIP
🟢 @asr2003 Jul 7, 2024, 6:32:09 PM WIP
🟢 @coder1152 #7278

algora-pbc[bot] avatar Jun 23 '24 02:06 algora-pbc[bot]

/attempt #7278

Implementation Plan:

  1. Replace gon with Custom Notarization Script

  2. Remove gon dependency

  3. Create custom notarization script

I'd recommend implementing a custom notarization script using notarytool. This approach gives you more control and ensures we are using Apple's latest recommended tool.

Options

unworld11 avatar Jun 24 '24 09:06 unworld11

@vadi2 I am interested to solve this issue. But the referenced PR https://github.com/confluentinc/cli/pull/2346/files is mostly done in the goreleaser.yml. What is our equivalent file we have for it in Mudlet. It could get me to quickly get it into the issue :)

asr2003 avatar Jul 07 '24 18:07 asr2003

Hey, build-mudlet.yml would be the starting point - and we have some scripts it calls out to after

vadi2 avatar Jul 07 '24 18:07 vadi2

Thanks! @vadi2 for quick response

With this /attempt #7278

Algora profile Completed bounties Tech Active attempts Options
@asr2003 1 bounty from 1 project
JavaScript, Go,
HTML & more
﹟689
Cancel attempt

asr2003 avatar Jul 07 '24 18:07 asr2003

/bounty $200

vadi2 avatar Aug 07 '24 07:08 vadi2

I have left off this issue due to exams :) I will wrap it up now and submit a PR very soon with the approach we discussed earlier!

asr2003 avatar Aug 07 '24 07:08 asr2003

@vadi2 I have submitted PR https://github.com/Mudlet/Mudlet/pull/7416. However, when I push commits, the signing and notarizing is skipped because MACOS_SIGNING_PASS is not available. To test, please push test commit in the PR or start build using mudlet machine account, otherwise the credentials do not get populated i.e MACOS_SIGNING_PASS, AC_USERNAME, AC_PASSWORD.

coder1152 avatar Aug 30 '24 17:08 coder1152

I merged this in https://github.com/Mudlet/Mudlet/pull/7491, but @coder1152 you will get the bounty nonetheless:

/tip $200 @coder1152

vadi2 avatar Dec 14 '24 08:12 vadi2

@coder1152: You just got a $200 tip! 👉 Complete your Algora onboarding to collect your payment.

algora-pbc[bot] avatar Dec 14 '24 08:12 algora-pbc[bot]

@coder1152 just confirming that you got the bounty?

vadi2 avatar Dec 24 '24 10:12 vadi2

🎉🎈 @coder1152 has been awarded $200! 🎈🎊

algora-pbc[bot] avatar Dec 24 '24 11:12 algora-pbc[bot]

@vadi2 I have received the bounty. Thanks.

coder1152 avatar Dec 24 '24 12:12 coder1152