Fix: stop bold and faint from affecting game text if BoldIsBright option used

[SlySven]

Brief overview of PR changes/additions

Gate the action of the Bold and Faint SGR codes so that they only have the presentation effects on the text font if the BoldIsBright option is NOT set.

Motivation for adding to Mudlet

It has been noted that recent changes made by #7010 changed the way that the Set Graphics Rendiion for the BOLD effect (value 1) now aways emboldens text when it is seen instead of not doing so when it is associated with a basic eight fore ground colour code (values 30 to 37).

Other info (issues closed, discussion etc)

This could close #7256.

A rethink has caused me to consider whether I can make it so that bold (and faint) can still be used if "Bold is Bright" is enabled by only considering the 1 code to be used to select the brighter colour if it is within the same <SGR> sequence. Otherwise, if it is separate, then it still does the bold/faint effect. It may be that Heiko's original code effectively did that!

[mpconley]

/refresh links

[vadi2]

/create links

[add-deployment-links[bot]]

Hey there! Thanks for helping Mudlet improve. :star2:

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/e3cd9a/Mudlet-4.17.2-testing-pr7277-382b793a-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/8938a2/Mudlet-4.17.2-testing-pr7277-382b793a.dmg
• windows 64 bit: https://make.mudlet.org/snapshots/c029b7/Mudlet-4.17.2-testing-pr7277-382b793a-windows-64.zip
• windows 32 bit: https://make.mudlet.org/snapshots/5c7375/Mudlet-4.17.2-testing-pr7277-382b793a-windows-32.zip

No need to install anything - just unzip and run. Let us know if it works well, and if it doesn't, please give details.

[SlySven]

Closed in favour of the better (IMVHO) #7280.