ThemeManager icon indicating copy to clipboard operation
ThemeManager copied to clipboard

ThemeManager planned improvements, feedback wanted

Open digitaldirk opened this issue 1 year ago • 9 comments

Hi,

I would like to become a main contributor/maintainer for this project.

Contribution Ideas:

  1. Update demo project (maybe add to mublazor docs)
  2. Add more options (upcoming skeleton color for example: https://github.com/MudBlazor/MudBlazor/pull/9815)
  3. Add presets (Default, pastel, neon,...)
  4. Ability to load custom fonts
  5. Exporting/importing themes (See #3)
  6. Improve readme
  7. Performance/stability
  8. Diagnostics (warnings for accessibility and contrast for example)
  9. Add tests
  10. Make things more compact overall (dense/margin) to be able to show as many things as possible on demo page.

Would like to discuss these further here with the community.

digitaldirk avatar Sep 17 '24 17:09 digitaldirk

I would like to become a main contributor/maintainer for this project. @ScarletKuro @henon

I think @henon would need your discord to discuss this.

As for the features. I think it's more to @Garderoben since he wrote 99% of the code, I'm just life supporting it. I can only say that the most requested feature was to import/export the theme settings.

ScarletKuro avatar Sep 17 '24 18:09 ScarletKuro

Here is a rough idea of having the drawer come up from the bottom instead. drawerchangestest

digitaldirk avatar Sep 18 '24 21:09 digitaldirk

Exporting/Uploading a json file is working, but still have some issues to work out. For exporting I would like to have multiple options.

What exports would you want?

  • .json file?
  • Copy/pasteable C# code?
  • .cs file?
  • Export just the colors as rgb/hex?

mudthemeupload

I will be away for 1-2 weeks so no coding progress will be made, but I will be sure to respond to any feedback.

digitaldirk avatar Sep 24 '24 16:09 digitaldirk

I would say you only need the json and copy/pastable C# code for the MudTheme for your project. Not sure about other formats

ScarletKuro avatar Sep 24 '24 16:09 ScarletKuro

Not sure if you'd like to add another item to the list? SSR support as it currently only works with CSR.

Allann avatar Nov 04 '24 00:11 Allann

It would be nice if all the configurable colors, elevations, texts etc would be on a sample page and were manageable by the thememanager. For me the thememanager on the side would be best, since I have a 40" monitor (wide), but perhaps you can make that configurable as well.

Miclo avatar Dec 02 '24 21:12 Miclo

Really good work, looking froward to next release. I would really like support for SSR as we could potetially use the theme manager in a lot of our projects.

cihlen avatar Feb 28 '25 16:02 cihlen

Really good work, looking forward to next release. I would really like support for SSR as we could potentially use the theme manager in a lot of our projects.

Except for dynamic dark/light mode I think ThemeManager works in SSR?

mikes-gh avatar Feb 28 '25 22:02 mikes-gh

Good!

0use-TE avatar Mar 05 '25 09:03 0use-TE

Any update?

edwRoland avatar May 16 '25 10:05 edwRoland

Hi all,

Thank you for all of your comments and suggestions. I am sorry for the big delay on this topic. I have recently made good progress and will have this code as a PR as soon as its ready. The changes I made need a lot of polish and some features still need to be implemented.

Demo: Image

digitaldirk avatar Jul 31 '25 20:07 digitaldirk

Really excited for this, when are we getting ?

bislerium avatar Aug 26 '25 18:08 bislerium

Regarding (from v9 board)

  1. Will ThemeManager support both 2/3 material designs, or just 3 going forward? Seems like having both options would be best for users and I suspect some will remain on 2 for some time.
  2. Feature to upgrade v2 theme to v3?

Don't worry about MD3 for now as we don't have any concrete plans, but we'll most likely want to support multiple types of themes in the future (Current theme and new MD3 theme at a minimum) #12053

danielchalmers avatar Nov 08 '25 04:11 danielchalmers