Daniele Scasciafratte
Daniele Scasciafratte
Based on https://github.com/Varying-Vagrant-Vagrants/VVV/issues/1971 we need a way to set another domain (also with subfolders) instead using the first one in the `hosts` section like it is now https://github.com/Varying-Vagrant-Vagrants/custom-site-template/blob/master/provision/vvv-init.sh#L7.
In this way with jquery migrate there aren't warnings anymore.
Ref: https://github.com/danirus/django-comments-xtd/issues/418 So this PR implements: * Various check to avoid crashes if `window.comments_props` is not defined or if the `comments` div not exists * Add the support to create...
With this PR the `javascript-catalog` or jsi18n from Django is not mandatory, so if you don't need the localization you can remove the dependence easily.
Ref https://github.com/danirus/django-comments-xtd/issues/414 On my tests seems working.
In this way the settings parameter can overwrite the values for the specific model
In this way works: ``` {% get_commentbox_props for article.self %} ```
So reading the code on https://github.com/danirus/django-comments-xtd/blob/master/django_comments_xtd/static/django_comments_xtd/js/src/index.js#L6 Seems that if the selector doesn't exist there is a JS crash (I can confirm it) but also if the comments are loaded after...
If I don't care about the markdown support I get from the JS bundle in this project: ``` Uncaught ReferenceError: remarkable is not defined http://127.0.0.1:8000/static/django_comments_xtd/js/django-comments-xtd-2.9.13.js:1330 ```
Adding this https://github.com/kucrut/vite-for-wp and an example with generator support