Daniele Scasciafratte comments

Results 1200 comments of


                                            Daniele Scasciafratte

Add empty variable declaration support

Sorry I confused the PR with another one about constants... About my proposal is to do what is written here https://github.com/amber-lang/amber/pull/432#issuecomment-2337232152

[Feature] access compile time environment variables

IF those are compiler variables I think that `env` can be confusing with the env functions we have in stdlib. Maybe `compiler_env` is better.

feature: add constant declarations

The idea of a function that returns always the same value I think that is the best and assure that can't change.

feature: add constant declarations

I think that we can move on with a function that return always the same value so we can assure the best compatibility. In the future we can think for...

feature: add constant declarations

@b1ek can you fix the conflicts so we can merge it?

No tests for variables

In `validity` there are a lot of tests but I don't think that there is one like this.

WP org now requires register_setting() with sanitization cb + incorrect chars in po filename

Can you share the changes you did to CMB2 for `register_setting`? Maybe we can do a PR and in meanwhile fix it.

input_prompt is not working when script is passed through a pipe

So just to understand it is an issue with the stdlib or it is the way you used that function? https://github.com/amber-lang/amber/blob/d3ceda317fc053ae9645e9f3c8f166657eba24e9/src/std/env.ab#L66 This is the bash code we have right now...

enh: Notification and Handling for Failed Embeddings

I think that is related to https://github.com/open-webui/open-webui/issues/10679#issuecomment-2976710842