XrmToolBox icon indicating copy to clipboard operation
XrmToolBox copied to clipboard

Cancel close doesn't cancel

Open rappen opened this issue 7 years ago • 8 comments

Example: Scene: After you have used FetchXMLBuilder and click close you get prompted to Save. Bug: If you click Cancel, it is treated the same as clicking No.

Ref https://github.com/rappen/FetchXMLBuilder/issues/218

rappen avatar Aug 31 '18 06:08 rappen

This is happening because the plugin is creating a setting file Rappen.XTB.FXB in AppData Settings which has the FetchXML is not cleared on close\cancel. Hope this helps in fixing the bug.

murthysrvn avatar Dec 01 '18 10:12 murthysrvn

After another discussion we had, it seems the save changes dialog is on your plugin. Therefore, I cannot do anything about it. Am I correct ?

MscrmTools avatar Feb 03 '19 13:02 MscrmTools

Researched a bit... and the ball bounces back, with this scenario: https://www.screencast.com/t/UoD0GoUSfGBb

I have also made the behavior in FXB more robust to reduce impact from the tool.

rappen avatar Mar 09 '19 17:03 rappen

Still an issue?

MscrmTools avatar Jul 31 '19 12:07 MscrmTools

Yes. But actually slightly different issue. Which might be worse, since me cancelling the close is ignored... https://www.screencast.com/t/OWgVDQbUB

rappen avatar Jul 31 '19 13:07 rappen

@rappen,

I tried reproduce this but i can't not sure if the fix is already in place. I still see that without saving if i close the tool the fetch xml is being restored. However i noticed that it's a new file created per connection Rappen.XTB.FXB_connectionName.xml. I assume if i create a new connection i will be seeing the empty fetch xml again.

murthysrvn avatar Aug 10 '19 06:08 murthysrvn

@murthysrvn yes the persistence of the queries is by conneciton.

rappen avatar Aug 10 '19 10:08 rappen

Hello @MscrmTools and @rappen https://user-images.githubusercontent.com/11160171/130398688-b01958c7-2f80-4798-a0d3-ed3d970045ce.mp4

I replicated this bug with the latest version of XrmToolBox. As you can see from the video I think the problem is with XrmToolBox when closing all tools, it doesn't consider the specific tools response.

BetimBeja avatar Aug 23 '21 06:08 BetimBeja