ngrx-forms icon indicating copy to clipboard operation
ngrx-forms copied to clipboard

Published 20 hours ago • verified publisher icon MrWolfZ

feat(validation): add between validators

Open jamie94bc opened this issue 4 years ago • 5 comments

Adds inclusive and exclusive between validators as a shorthand for combining the lessThan, greaterThan etc. validators and facilitating better error messages.

jamie94bc avatar Dec 12 '20 10:12 jamie94bc

Thank you @jamie94bc for this contribution. The code looks good. The only thing missing is an update to the validation docs (at docs/user-guide/validation.md). Please add entries for the two new validation functions to the table. After that is done I'll merge the PR and release a new version.

MrWolfZ avatar Dec 14 '20 18:12 MrWolfZ

Done!

jamie94bc avatar Dec 27 '20 13:12 jamie94bc

@MrWolfZ @dzonatan can this be merged?

jamie94bc avatar Feb 23 '21 18:02 jamie94bc

A bit late answer but I have no access for merging. Pinging @MrWolfZ

dzonatan avatar Apr 02 '21 07:04 dzonatan

This would be useful, I was just looking for this. Specifically, the advantage is to be able to indicate in the error message "This must be between x & y".

evantrimboli avatar Jul 31 '21 14:07 evantrimboli