ProjectRed icon indicating copy to clipboard operation
ProjectRed copied to clipboard

Framed wires/cables not rendering multiple passes of covers.

Open KitsuneAlex opened this issue 4 years ago • 3 comments

Describe the bug I've been working on CBM integration for my mod. It makes heavy use of the CCL rendering pipeline for it's own blocks so it was fairly easy to implement a multi-pass BlockMicroMaterial. However, after testing my implementation for a bit, i realized that when i put a CBM cover on one of the framed wire/cable types from ProjectRed, it only renders the first pass of my micro material. Because of that i assume that the cover rendering when already applied only renders the first pass in general, or rather only one RenderType.

I didn't make a PR for this because covers said parts of CBM (and therefore PR?) are gonna be rewritten anyways, especially regarding rendering, so i'm leaving this one to you.

To Reproduce I am the only one able to reproduce this as of right now, since the mod isn't released yet.

Expected behavior I am expecting the framed wires/cables to render all passes of a cover defined in it's BlockMicroMaterial.

Crash Log No crash.

Versions

  • CCL Version: 4.0.4.436
  • CBM Version: 3.0.3.122
  • ProjectRed Version: 4.11.0-beta-0

Screenshots/Videos The actual rendering when a cover is applied: Image How the covered part should look:

KitsuneAlex avatar Nov 22 '21 22:11 KitsuneAlex

Interesting. I’ll take a look. If I remember correctly, there was some logic to prevent rendering (or even applying) transparent materials to frames (because the underside wire is completely not rendered while there is a cover on it). I don’t recall any special handling of multi-layered micro materials.

MrTJP avatar Nov 22 '21 22:11 MrTJP

Alright, i honestly didn't really look into it myself too much yet, but if i find anything i'll let you know. Just thought you might be able to spot the issue quicker than me :) Also thanks for the quick reply!

KitsuneAlex avatar Nov 22 '21 22:11 KitsuneAlex

@MrTJP discord :)

covers1624 avatar Nov 23 '21 02:11 covers1624