ProjectRed icon indicating copy to clipboard operation
ProjectRed copied to clipboard

Microblocks crash on placing illuminated button

Open Somebodyisnobody opened this issue 3 years ago • 4 comments

Describe the bug Nullpointer exception when placing button on microblocks

To Reproduce Steps to reproduce the behavior:

  1. Place illuminated button on multipart block

Expected behavior Nothing like with the vanilla button.

Crash Log crash-2021-04-29_18.55.08-client.txt

Versions Checkout at bc91f0c89ff2ced2a1585504a57695106547c1fb

Screenshots/Videos

Somebodyisnobody avatar Apr 29 '21 17:04 Somebodyisnobody

I think this may have been fixed on CBMultipart side. Using the latest commit from 1.15 branch and I can place the button on a Microblock cover just fine. What version of CBM are you running?

Screen Shot 2021-04-29 at 9 58 25 PM

Btw, illumar buttons are not fully implemented yet. Still missing textures, etc.

MrTJP avatar Apr 30 '21 04:04 MrTJP

The client seems to crash when placing an illuminated button on a cover with solid block behind the cover. The screenshot shows all not crashing variants with green lamps. If someone tries to place the button on the cover behind the red lamp, the client is crashing. I think the button thinks it should be placed on the solid block, but it cannot because there is a cover before the solid block and thus crashing the client. Note that the second cover is not at the same position as the first cover.

2021-04-30_18 42 05

NDev8 avatar Apr 30 '21 16:04 NDev8

Forgot to comment, but this seems to be fixed in 1.16 version of CB Multipart. Will know more later today once I'm finished porting.

MrTJP avatar May 09 '21 01:05 MrTJP

Are Illumar Buttons still disabled in the 1.16 release? I see their recipe on the wiki but not in-game on Illumination 4.12.0.

SharkBaitDLS avatar Jul 02 '22 22:07 SharkBaitDLS

Placement logic around multipart buttons has been re-written in CBMultipart (https://github.com/TheCBProject/CBMultipart/commit/ee4de5337c994f4b47b21c82e10ca60093366ede)

As for Illuminated buttons, they are not in atm. If/when they return, this issue won't apply anymore

MrTJP avatar Nov 21 '23 13:11 MrTJP