hello.js icon indicating copy to clipboard operation
hello.js copied to clipboard

Added SimpleLogin to the available login/signup modules

Open nguyenkims opened this issue 4 years ago • 10 comments

SimpleLogin is a social login provider that focus on protecting user identity. More info can be found on https://simplelogin.io

The PR is largely inspired from spotify and amazon one 😊.

nguyenkims avatar Aug 11 '19 22:08 nguyenkims

Hi has anyone had time to look at this PR please?

nguyenkims avatar Sep 18 '19 11:09 nguyenkims

Re

nguyenkims avatar Sep 24 '19 16:09 nguyenkims

Hi, can you remove it from the hello.all.js build, otherwise all good

MrSwitch avatar Sep 25 '19 18:09 MrSwitch

@MrSwitch You mean removing simplelogin from Gruntfile.js right? In this case does user need to include simplelogin.js explicitly in order to use it?

nguyenkims avatar Sep 25 '19 23:09 nguyenkims

@MrSwitch is there anything that I need to address in this PR?

nguyenkims avatar Nov 02 '19 16:11 nguyenkims

@MrSwitch

nguyenkims avatar Nov 12 '19 20:11 nguyenkims

@MrSwitch You mean removing simplelogin from Gruntfile.js right? In this case does user need to include simplelogin.js explicitly in order to use it?

Yes please do, indeed they can pull it in separatly, there's a few examples in the demos/ folder

MrSwitch avatar Nov 14 '19 10:11 MrSwitch

@MrSwitch I'm not sure how that would work for users, could you please point me to the right example? From what I see on the documentation, a new provider needs to be added into the hello.all.js right?

nguyenkims avatar Nov 14 '19 14:11 nguyenkims

Any news on this?

nguyenkims avatar Jan 09 '20 20:01 nguyenkims

re

nguyenkims avatar Oct 29 '20 18:10 nguyenkims