Andrew Dodson

Results 101 comments of Andrew Dodson

So I bundle my own hello/dist files. It's a clunky step but you literally concat the files you need, see Gruntfile.js. The scenario you've described is something I really want...

Another suggestion, define `window.hello`... ``` javascript import Hello from '../../js/vendor/hello/dist/hello'; window.hello = Hello; import '../../js/vendor/hello/src/modules/instagram'; ... ```

Yes, it's client side only so `window` object is expected and presumably unavailable when rendered isoporohically. Wrapping it in something which runs only in the client is the way to...

Maintains its own state. So you probably just want to wrap the whole helloInit into a module with a simple `export hello` at the end. So initiation is only done...

You could have just pushed again, the previous PR would have reflected your changes.

Can i add another suggest feature which is kind of related to being a promise #1078

Here's a real world example https://github.com/MrSwitch/tricks/blob/d65e63be17de9166e668d0195669f6bfea27ba80/package.json#L92-L120 - it took a few attempts (refer to the file history for all the previous wrong turns)

This is going to take a little while to go through and test it isn't breaking for some services supported by hellojs

Seems reasonable, open to Pull Request