alive icon indicating copy to clipboard operation
alive copied to clipboard

Complete quoting for parameters of some CMake commands

Open elfring opened this issue 9 years ago • 1 comments

Some parameters (like "${SDL2_INCLUDE_DIR}") are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

elfring avatar Apr 24 '16 15:04 elfring

Perhaps its worth changing the CI builds to have a space in the path on purpose to weed out these issues.

MrSapps avatar Apr 24 '16 16:04 MrSapps