quinn icon indicating copy to clipboard operation
quinn copied to clipboard

Published 20 hours ago • verified publisher icon MrPowers

Ignore nullable for validate_schema

Open cosmincatalin opened this issue 2 years ago • 2 comments

Are you open to a PR for adding an option to validate_schema so as to ignore the nullable property?

cosmincatalin avatar Mar 21 '22 11:03 cosmincatalin

@cosmincatalin - Yep, sounds like a good addition, please feel free to send a pull request. Thanks for opening this issue.

MrPowers avatar Mar 22 '22 12:03 MrPowers

We have opened PR #44

cosmincatalin avatar Apr 24 '22 19:04 cosmincatalin

Next steps: review the PR, make sure it can get merged and will be 100% backwards compatible, merge it, let all interested stakeholders know, and apologize profusely for taking so long.

MrPowers avatar Oct 17 '22 00:10 MrPowers

How's the review going, @MrPowers ? We're anxiously waiting to get rid of our custom code and replace it with quinn alone.

cosmincatalin avatar Dec 30 '22 17:12 cosmincatalin

@MrPowers I think we can merge this PR :)

robertkossendey avatar Jan 23 '23 10:01 robertkossendey

@cosmincatalin - this was merged, sorry for the delay.

MrPowers avatar Feb 17 '23 21:02 MrPowers