mack icon indicating copy to clipboard operation
mack copied to clipboard

Published 20 hours ago • verified publisher icon MrPowers

Create Pull Request Template

Open robertkossendey opened this issue 1 year ago • 5 comments

We should create a template for pull requests, requiring the contributor to tick a box stating that he read the contributing guidelines (CONTRIBUTING.md). By that we can make sure that the contributor has run the pre-commit hooks on his machine (flake8, black and pytest).

robertkossendey avatar Mar 07 '23 14:03 robertkossendey

Yes, I like this idea, thank you for making this suggestion. Would be great for someone to grab this.

MrPowers avatar Mar 08 '23 00:03 MrPowers

@MrPowers we should also add an Issue Template with "I would like to contribute" checks as well. More and more people are opening issues / contributing, so this will come in handy.

robertkossendey avatar Mar 11 '23 22:03 robertkossendey

@robertkossendey - yea, an issue template with "I would like to contribute" would be great as well. Good idea!

MrPowers avatar Mar 12 '23 12:03 MrPowers

Would be great if pure documentation commits don't require pre-commit setup as it may scare off folks who otherwise have valuable contributions. Can you exclude changes to the README.md from pre-commit hooks requirement by default somehow?

Triamus avatar Mar 17 '23 10:03 Triamus

@robertkossendey Can I take this one? It will be my first issue, so I might just need a little guidance.

paulooctavio avatar May 14 '24 20:05 paulooctavio