mack icon indicating copy to clipboard operation
mack copied to clipboard

Test every edge case

Open MrPowers opened this issue 2 years ago • 2 comments

We should write tons of tests to explore every nook and cranny of the public facing APIs. We want to always fail gracefully and give the user a really amazing description of what went wrong.

We should check None input, null columns, null input, empty DataFrames, DataFrames with weird schemas... the common causes of problems.

MrPowers avatar Dec 29 '22 04:12 MrPowers

@MrPowers you still want this worked on? I can take the first shot at this.

danielbeach avatar Mar 23 '23 18:03 danielbeach

@danielbeach - yep, this one is still open. Try to break stuff ;)

For example, mack.drop_duplicates_pkey(delta_table=deltaTable, primary_key="col1", duplication_columns=["col2", "col3"]) assumes that col1 is in fact a unique primary key. What if it's not unique? What's the best user experience?

I'll assign you to the issue & thanks in advance!

MrPowers avatar Mar 23 '23 19:03 MrPowers