chispa icon indicating copy to clipboard operation
chispa copied to clipboard

Add allow_nan_equality option to assert_approx_df_equality

Open mitches-got-glitches opened this issue 4 years ago • 3 comments

I feel like this would be quite useful. Were there any design choices for why it wasn't included or would this be a useful addition?

https://github.com/MrPowers/chispa/blob/500793efe14b1975b86fb1a923ee6cd68ba559d8/chispa/dataframe_comparer.py#L38-L40

mitches-got-glitches avatar Apr 22 '21 15:04 mitches-got-glitches

@mitches-got-glitches - yea, allow_nan_equality is probably even more important for assert_approx_df_equality. Feel up for sending me a PR?

MrPowers avatar Apr 22 '21 17:04 MrPowers

Hi @MrPowers , yes I will have a go this week! Cheers

mitches-got-glitches avatar Apr 26 '21 10:04 mitches-got-glitches

Awesome, thanks @mitches-got-glitches!

MrPowers avatar Apr 26 '21 11:04 MrPowers