firefox-csshacks icon indicating copy to clipboard operation
firefox-csshacks copied to clipboard

autohide transition bug and default delay

Open AveYo opened this issue 3 years ago • 7 comments

autohide_bookmarks_and_main_toolbars gets stuck half-way trough in animation transition when the mouse movement to the top was fast (and most people tend to do that) autohide_delay_animation_bug

I propose removing that animation entirely, it's superfluous anyway.

The --uc-autohide-toolbar-delay of just 600ms is also something to consider increasing to at least 3000ms,
it would improve accessibility considerably and induce less strain (most people can't even put a finger on why they can't adjust to autohide toolbars - it's usually because of the very short delay).

AveYo avatar Dec 04 '20 11:12 AveYo

I honestly don't think that your opinion about removing the transition is a common one. For what I've seen people, especially who are into autohiding stuff in general, tend to like transitions even relatively obnoxious animations.

There is probably some room for optimization but I think the 600ms is an OK default. I mean, it's just a default anyway and one can modify it however they like.

I could for sure add a comment to set the transition-duration to 0 to effectively disable the animation. Or just add a new variable for it.

MrOtherGuy avatar Dec 04 '20 15:12 MrOtherGuy

The transition is broken here - just check the screenshot it stays that squeezed-size way for the duration, it's worse when the bookmarks toolbar is also toggled. Reducing the transition duration does prevent the issue. Tested on multiple PCs, firefox 83, windows 2004 / 20H2, hardware acceleration, webrender enabled and working. On second thought, I agree the delay can be annoying either way, so 600ms is probably OK default. I have previously given up on auto-hiding toolbars because of bugs for years, and only recently decided to give it a go again, so maybe my report was rushed out due to excitement. Thanks for your work!

AveYo avatar Dec 04 '20 17:12 AveYo

Sure it stays in intermediate state for a bit, but I don't think it's broken. Like, sure if it was possible to make it hide immediately but only if the transition wasn't finished then that would be ideal but that cannot be done with css. At least I don't think it can, but if someone figures out a way then I would include that.

Nonetheless, I might revise various autohide-x styles and perhaps make the default transition a bit faster like around 100ms because it feels snappier while still being obviously animated.

MrOtherGuy avatar Dec 04 '20 18:12 MrOtherGuy

Is there a quick way to add exception for about:config? And, could you make a non-overlay version?

AveYo avatar Dec 08 '20 18:12 AveYo

What do you mean by exception?

Nonetheless, a simple non-overlay non-animated version would go like this:

:root[sessionrestored] #navigator-toolbox:not(:focus-within):not(:hover) > toolbar {
  max-height: 0px !important;
  min-height: 0px !important;
}
#navigator-toolbox > toolbar{ transition: none !important }

MrOtherGuy avatar Dec 08 '20 21:12 MrOtherGuy

Original overlay version is way better than a static one, and the default delay is fine (I just disable the animation). Showing on customize and on urlbar focus are so great, that I am after even more ergonomics. What would make it perfect imho would be also showing with the right-click context menu (anywhere in page).
That way I could quickly visually inspect the urlbar for sec/perm/autoplay/ublock and other icons with a counter,
without moving the mouse all the way to the top or triggering urlbar with the keyboard (no macro-able mouse atm).
Tried to implement it myself but I'm not familiar with userchrome, figured I ask (last time, I promise 🌗) for an expert advice!

AveYo avatar Dec 10 '20 21:12 AveYo

I included a way to show toolbars when context menu or popups are hovered into autohide_toolbox.css and autohide_boookmarks_and_main_toolbars.css in 5d18237e62ec3407df89ab5ba811c79dee084db2

The caveat is that there isn't really a way to select which popups/context-menus trigger toolbars. So you get what you get. It is disabled by default though because I suspect its not wanted most of the time.

MrOtherGuy avatar Dec 11 '20 08:12 MrOtherGuy