InvSync icon indicating copy to clipboard operation
InvSync copied to clipboard

Sync Advancement Crashes

Open AbrasiveBoar902 opened this issue 1 year ago • 2 comments

Maybe because writeAdvancementData modifies advancementToProgress(or other LinkedHashMaps) while PlayerAdvancementTracker/sendUpdate is reading it with iterator.

Caused

Description: Ticking entity

java.util.ConcurrentModificationException
at java.base/java.util.LinkedHashMap$LinkedHashIterator.nextNode(LinkedHashMap.java:756)
at java.base/java.util.LinkedHashMap$LinkedKeyIterator.next(LinkedHashMap.java:778)
at net.minecraft.class_2985.method_12876(class_2985.java:285)
at net.minecraft.class_3222.method_5773(class_3222.java:428)
at net.minecraft.class_3218.method_18762(class_3218.java:621)
at net.minecraft.class_1937.method_18472(class_1937.java:561)
at net.minecraft.class_3218.method_18765(class_3218.java:411)
at net.minecraft.server.MinecraftServer.redirect$zkm000$ficUpdateSuppressionCrashTick(MinecraftServer.java:3711)
at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:871)
at net.minecraft.class_3176.method_3813(class_3176.java:312)
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:811)
at net.minecraft.server.MinecraftServer.handler$zbc000$modifiedRunLoop(MinecraftServer.java:2810)
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:651)
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:257)
at java.base/java.lang.Thread.run(Thread.java:833)

AbrasiveBoar902 avatar Mar 03 '23 16:03 AbrasiveBoar902

Oh pain, I'm surprised this has never come up. I'll look into fixing this hopefully this weekend.

MrNavaStar avatar Mar 03 '23 17:03 MrNavaStar

Do you have any more logs you can share with me? Or any steps to reproduce the error?

MrNavaStar avatar May 06 '23 17:05 MrNavaStar