mrmc icon indicating copy to clipboard operation
mrmc copied to clipboard

jsonrpc websocket api header not handled case insensitive

Open L-Henke opened this issue 4 years ago • 2 comments

I found a problem with the handling of headers in a websocket connection to the json-rpc API. I'm using Home Assistant to connect to the API of MrMC. A recent change in the used aiohttp library broke this connection, because aiohttp changed a header from Connection: Upgrade to Connection: upgrade. This is compliant to the RFC which states, that this variable should be treated case-insensitive.

Current versions of Kodi are working fine with the changed header, but if you connect to MrMC, the connection runs into a timeout.

The jsonrpc version of MrMC seems to be way behind the upstream Kodi version, but maybe it is possible to upgrade your version or change the parsing of the connection headers to be case-insensitive.

L-Henke avatar Jan 18 '21 15:01 L-Henke

should be fixed in the next version, we will push the TestFlight version with it soon.

what platform are you running MrMC on?

amet avatar Jan 24 '21 17:01 amet

I'm running MrMC on an Apple TV 4K.

L-Henke avatar Jan 24 '21 17:01 L-Henke