Loop icon indicating copy to clipboard operation
Loop copied to clipboard

🐛 Window snapping won't work in secondary display screen

Open ClarkGeng996 opened this issue 1 year ago • 2 comments

Bug Description

  1. My secondary screen is above my macbook internal screen. Like the attachment. 13891715412652_ pic
  2. In internal screen, window snapping works well.
  3. If you snap the windows from internal screen to external screen edge without interruption, it also works well.
  4. SO the bad case is if you sanp the windows already in external screen to its edge, it won't works.

Steps To Reproduce

Sanp the windows already in external screen to its edge, the funtion of window snapping won't works.

Expected Behavior

Obviously window snapping should work well in any displays.

Actual Behavior

SO the bad case is if you sanp the windows already in external screen to its edge, it won't works.

Screenshots

No response

MacOS Version

Sonoma 14.4.1 (23E224)

Loop Version

Version 1.0.0-beta.15 (817)

Additional Context

Thanks for your hardworking to building this brilliant software.

Final Checks

  • [X] My issue title is descriptive
  • [X] This is a single bug (multiple bugs should be reported individually)

ClarkGeng996 avatar May 11 '24 07:05 ClarkGeng996

Thanks for the report! However, I am unable to reproduce that bug. Would you be able to send a quick screen recording of this bug if possible?

MrKai77 avatar May 11 '24 17:05 MrKai77

No Problem. Please see the attached file.

https://github.com/MrKai77/Loop/assets/73984994/75a7efd6-9e56-4423-ab08-3f511a432940

ClarkGeng996 avatar May 14 '24 02:05 ClarkGeng996

Alright, somehow I was just able to reproduce this issue! I will definitely try and fix this by the next update :)

MrKai77 avatar May 21 '24 03:05 MrKai77

So great news! Thanks for your hard working! Looking forward to next update and checking update everyday. Loop is a REAL macOS style window management App. Excited.

ClarkGeng996 avatar May 22 '24 06:05 ClarkGeng996

Try this :) Loop.zip

Turns out that Loop wasn't correctly calculating mouse coordinates on external screens when window snapping :P

MrKai77 avatar May 23 '24 23:05 MrKai77

Hi Mrkai77, thanks for your new version. BTW. It seems you changed trigger condition for window snapping?Only if I drop window to the very top of my screen(just same as magnet) instead of at the beginning of touching menu bar. I think the original method is better for user.

ClarkGeng996 avatar May 27 '24 06:05 ClarkGeng996

That change was made by #212. I will look into it again, since I do find that it does become a little hard to snap windows to the top when two screens are stacked vertically too :)

MrKai77 avatar May 27 '24 13:05 MrKai77