Jithil P Ponnan
Jithil P Ponnan
Will add test cases if this feature is acceptable
@MoLow I have changed the value of `clear` from `'\u001bc'` to `'\u001b[0m'`. Please check.
> There are some values which look quite broken with this change: > > * ` ./node -e 'console.warn(new Error);console.error(new Error)'` shows that that color stays until the first greyed...
How to run CITGM?
@aduh95 Please review.
@ruyadorno how to run the citgm? Using the citgm-smoker jenkin?
> would prefer it to be just a highlight of that header rather than the entire error stack - in order for that bit to be a proper highlight -...
> I'm sorry @MrJithil but while this is a good work in progress and I initially had no comments, I took some time thinking a bit more about this change...
> > Currently we are skipping the non-string types. So, `node -e 'console.error(new Error("ERR"))'`. will be skipped colouring. > > Then I don't think this PR fixes #40361, might be...
> I thought a bit more about this after talking with a few other folks and changed my mind on the remaining objection. LGTM 👍 thank you. proceeding further.