ComfyUI-3D-Pack icon indicating copy to clipboard operation
ComfyUI-3D-Pack copied to clipboard

[Enhancement]CUDA 12.8

Open greenhandzdl opened this issue 9 months ago • 8 comments

## ComfyUI-Manager: EXECUTE => ['/opt/comfyui/ComfyUI/venv/bin/python', 'install.py']
[!] Traceback (most recent call last):
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/install.py", line 19, in <module>
[!]     from build_utils import (
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/_Pre_Builds/_Build_Scripts/build_utils.py", line 54, in <module>
[!]     CUDA_VERSION = get_cuda_version()
[!]                    ^^^^^^^^^^^^^^^^^^
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/_Pre_Builds/_Build_Scripts/build_utils.py", line 49, in get_cuda_version
[!]     raise RuntimeError(f"Please install/reinstall CUDA tookit with any of the following supported version: {build_config.supported_cuda_versions}")
[!] RuntimeError: Please install/reinstall CUDA tookit with any of the following supported version: ['12.4', '12.1', '11.8']
[!] Traceback (most recent call last):
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/install.py", line 19, in <module>
[!]     from build_utils import (
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/_Pre_Builds/_Build_Scripts/build_utils.py", line 54, in <module>
[!]     CUDA_VERSION = get_cuda_version()
[!]                    ^^^^^^^^^^^^^^^^^^
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/_Pre_Builds/_Build_Scripts/build_utils.py", line 49, in get_cuda_version
[!]     raise RuntimeError(f"Please install/reinstall CUDA tookit with any of the following supported version: {build_config.supported_cuda_versions}")
[!] RuntimeError: Please install/reinstall CUDA tookit with any of the following supported version: ['12.4', '12.1', '11.8']
[!] 
[!] During handling of the above exception, another exception occurred:
[!] 
[!] Traceback (most recent call last):
[!]   File "/opt/comfyui/ComfyUI/custom_nodes/comfyui-3d-pack/install.py", line 84, in <module>
[!]     cstr("Comfy3D install failed: Dependency installation has failed. Please install manually: https://github.com/MrForExample/ComfyUI-3D-Pack/tree/main/_Pre_Builds/README.md.").error.print()
[!]     ^^^^
[!] NameError: name 'cstr' is not defined. Did you mean: 'str'?
install script failed: comfyui-3d-pack
[ComfyUI-Manager] Installation failed:
Failed to execute install script: [email protected]

[ComfyUI-Manager] Queued works are completed.
{'install': 1}

After restarting ComfyUI, please refresh the browser.

greenhandzdl avatar Mar 22 '25 07:03 greenhandzdl

same problem

linhengbin avatar Mar 27 '25 06:03 linhengbin

Same problem here did you find a solution ?

Jansi2012 avatar Mar 27 '25 10:03 Jansi2012

i think you can't compile pytorch3d with versions higher than cuda 12.4. so that would be the limit for this package

CursedGonzz avatar Mar 29 '25 15:03 CursedGonzz

I mean the relevant config in _Pre_Builds/_Build_Scripts/build_utils.py dedicate the incompatible version of cuda

greenhandzdl avatar Mar 31 '25 14:03 greenhandzdl

add 12.8 to build_config.yaml file inside Build_Scripts folder

supported_cuda_versions: ["12.8","12.4", "12.1", "11.8"]

i was able to build

bilersan avatar Apr 03 '25 13:04 bilersan

add 12.8 to build_config.yaml file inside Build_Scripts folder

supported_cuda_versions: ["12.8","12.4", "12.1", "11.8"]

i was able to build

so did you run this node with cu128 successfully? can you provide more specific steps please

gilguo95 avatar Apr 08 '25 17:04 gilguo95

This worked for me on Ubuntu 24.04 (with patience!)...obviously this is my paths, etc:

cd ~/code/ComfyUI/custom_nodes
git clone [email protected]:MrForExample/ComfyUI-3D-Pack.git
vi ComfyUI-3D-Pack/_Pre_Builds/_Build_Scripts/build_config.yaml

supported_cuda_versions: ["12.8", "12.4", "12.1", "11.8"]
cuda_version: "12.8"

torch:
	version: "2.7.0"
torchvision:
	version: "0.22.0"
xformers:
	version: "0.0.30"

source ~/code/ComfyUI/.venv/bin/activate
python ComfyUI-3D-Pack/_Pre_Builds/_Build_Scripts/auto_build_all.py
cd ~/code
git clone [email protected]:traveller59/spconv.git
cd spconv
uv pip install -e .
uv pip install kiui
cd ~/code
git clone [email protected]:NVlabs/nvdiffrast.git
cd nvdiffrast
python setup.py install
cd ~/code
git clone [email protected]:rusty1s/pytorch_scatter.git
cd pytorch_scatter
uv pip install -e .
cd ~/code
git clone [email protected]:facebookresearch/pytorch3d.git
cd pytorch3d
python setup.py install
sudo apt install -y libegl1-mesa-dev

flavour avatar May 06 '25 18:05 flavour

This worked for me on Ubuntu 24.04 (with patience!)...obviously this is my paths, etc:

cd ~/code/ComfyUI/custom_nodes
git clone [email protected]:MrForExample/ComfyUI-3D-Pack.git
vi ComfyUI-3D-Pack/_Pre_Builds/_Build_Scripts/build_config.yaml

supported_cuda_versions: ["12.8", "12.4", "12.1", "11.8"]
cuda_version: "12.8"

torch:
	version: "2.7.0"
torchvision:
	version: "0.22.0"
xformers:
	version: "0.0.30"

source ~/code/ComfyUI/.venv/bin/activate
python ComfyUI-3D-Pack/_Pre_Builds/_Build_Scripts/auto_build_all.py
cd ~/code
git clone [email protected]:traveller59/spconv.git
cd spconv
uv pip install -e .
uv pip install kiui
cd ~/code
git clone [email protected]:NVlabs/nvdiffrast.git
cd nvdiffrast
python setup.py install
cd ~/code
git clone [email protected]:rusty1s/pytorch_scatter.git
cd pytorch_scatter
uv pip install -e .
cd ~/code
git clone [email protected]:facebookresearch/pytorch3d.git
cd pytorch3d
python setup.py install
sudo apt install -y libegl1-mesa-dev

works for me windows 11 and nvidia 5080

fangguanya avatar May 11 '25 13:05 fangguanya

ps: gonna check if I can adapt this for my Win build since some one was able to fix Tks

CrisOrlandoBR avatar Jun 05 '25 16:06 CrisOrlandoBR

This worked for me on Ubuntu 24.04 (with patience!)...obviously this is my paths, etc:

cd ~/code/ComfyUI/custom_nodes
git clone [email protected]:MrForExample/ComfyUI-3D-Pack.git
vi ComfyUI-3D-Pack/_Pre_Builds/_Build_Scripts/build_config.yaml

supported_cuda_versions: ["12.8", "12.4", "12.1", "11.8"]
cuda_version: "12.8"

torch:
	version: "2.7.0"
torchvision:
	version: "0.22.0"
xformers:
	version: "0.0.30"

source ~/code/ComfyUI/.venv/bin/activate
python ComfyUI-3D-Pack/_Pre_Builds/_Build_Scripts/auto_build_all.py
cd ~/code
git clone [email protected]:traveller59/spconv.git
cd spconv
uv pip install -e .
uv pip install kiui
cd ~/code
git clone [email protected]:NVlabs/nvdiffrast.git
cd nvdiffrast
python setup.py install
cd ~/code
git clone [email protected]:rusty1s/pytorch_scatter.git
cd pytorch_scatter
uv pip install -e .
cd ~/code
git clone [email protected]:facebookresearch/pytorch3d.git
cd pytorch3d
python setup.py install
sudo apt install -y libegl1-mesa-dev

works for me windows 11 and nvidia 5080

Hi

Could you show me the steps to make it work on Windows ?

I did this but some commands are not for win

tks

CrisOrlandoBR avatar Jun 05 '25 22:06 CrisOrlandoBR

In Windows command line you can activate the Comfy enviroment, in my case is "E:\AI\ComfyUI\venv\Scripts\activate", an then call pip install git+https://github.com/facebookresearch/pytorch3d.git They fixed the windows build in the latest commits so it should work fine now. Replace the git url for the other packages, like nvdiffrast, if needed.

CursedGonzz avatar Jun 06 '25 21:06 CursedGonzz

thanks @flavour we added cuda 12.8 support with build wheels for windows

DenisKochetov avatar Aug 01 '25 08:08 DenisKochetov