sphinx_rtd_dark_mode icon indicating copy to clipboard operation
sphinx_rtd_dark_mode copied to clipboard

Add a Lighter Dark Theme

Open MrDogeBro opened this issue 3 years ago • 10 comments

This would add a lighter dark theme as some people think that the current theme is to dark (understandably). This would most likely move the current theme to being a high-contrast theme and add a normal dark theme which is a bit lighter.

MrDogeBro avatar May 28 '21 22:05 MrDogeBro

In case you need docs using this great package, have a look at https://mys-lang.org/. I think a lighter dark theme would be nice!

eerimoq avatar Jul 27 '21 17:07 eerimoq

@eerimoq thanks! I see you have modified the theme manually to suit your color scheme. When v2 is released tho, you should be able to do this all from the config file and release community themes which should be exciting! Also, would you mind if I possibly use some parts of the color scheme you created in a new official theme?

MrDogeBro avatar Jul 28 '21 13:07 MrDogeBro

Yeah, I noticed you have done lots of work of the 2.0.0 branch. Will be exciting to use that instead of the copy in my repository.

It's based on the Github color scheme. Feel free to use it.

eerimoq avatar Jul 28 '21 14:07 eerimoq

Ok sounds good thanks!

MrDogeBro avatar Jul 28 '21 14:07 MrDogeBro

My latest changes can be found here: https://github.com/mys-lang/mys/tree/main/mys/sphinx_rtd_dark_mode

eerimoq avatar Jul 28 '21 14:07 eerimoq

I've made more changes, just to let you know. All found in the link in the previous comment.

eerimoq avatar Aug 05 '21 18:08 eerimoq

Just discovered this extension and installed it. Thanks for the work! I'm amazed there aren't more dark themes out there for Sphinx.

I don't personally mind how dark the dark theme is, but in some cases it seems to have a dark-on-dark color combination that's difficult to read. For example, the environment variable name in this shell code snippet:

image

zaneselvans avatar Sep 24 '21 23:09 zaneselvans

Thanks! Im glad you like it! However, that seems like a bug in the dark theme so if you wouldn't mind opening a separate issue for that that would be great! Thanks!

MrDogeBro avatar Sep 25 '21 12:09 MrDogeBro

Done! See #27

That slate theme from Material on MkDocs is also great. Looking forward to trying out the new options too.

zaneselvans avatar Sep 25 '21 17:09 zaneselvans

Thanks! Glad your looking forward to it!

MrDogeBro avatar Sep 25 '21 18:09 MrDogeBro